Explicitly type convert metric values to Number(). #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarlokc
reviewed
Jan 13, 2022
| @@ -180,9 +180,9 @@ export class MetricsContext { | |||
| public putMetric(key: string, value: number, unit?: Unit | string): void { | |||
| const currentMetric = this.metrics.get(key); | |||
| if (currentMetric) { | |||
| currentMetric.addValue(value); | |||
| currentMetric.addValue(Number(value)); | |||
There was a problem hiding this comment.
@bobtfish What do you think of throwing an exception if we find that value is not a number?
Javascript has weird/grey areas when it comes to parsing. It might make more sense to delegate the parsing to whoever is calling putMetric.
There was a problem hiding this comment.
Anything that isn’t just passing the value, quoting it and having cloudwatch silently drop it sounds fine to be honest.
I just didn’t want to make an API that currently fails silently start throwing exceptions, as that’s not a backwards compatible change (and so implies a new major version if semver is being used).
But if throwing an exception is the way that the AWS team wants to go then that’s fine with me!
Closed
Closed
|
Fixed by #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
This is a suggested / potential fix for the issue in #106 where it's possible to submit correct looking metrics which are then interpreted as
0by AWS because the value ends up quoted in the generated JSON